Support ExperimentData in MetadataToFloat & MapKeyToFloat transforms #3934
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Supports transforming `ExperimentData` with `MetadataToFloat` & `MapKeyToFloat` transforms. The transform constructor is also updated to support extracting the observations for the relevant parameters from `experiment_data`. For `MapKeyToFloat`, the actual transform is no-op, since we have the map keys in `observation_data` and we can simply extract them from there in `Adapter`. Background: As part of the larger refactor, we will be using `ExperimentData` in place of `list[Observation]` within the `Adapter`. - The transforms will be initialized using `ExperimentData`. The `observations` input to the constructors may be deprecated once the use cases are updated. - The training data for `Adapter` will be represented with `ExperimentData` and will be transformed using `transform_experiment_data`. - For misc input / output to various `Adapter` and other methods, the `Observation / ObservationFeatures / ObservationData` objects will remain. To support these, we will retain the existing transform methods that service these objects. - Since `ExperimentData` is not planned to be used as an output of user facing methods, we do not need to untransform it. We are not planning to implement`untransform_experiment_data`. Reviewed By: ltiao Differential Revision: D76627256
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D76627256 |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3934 +/- ##
==========================================
- Coverage 95.97% 95.97% -0.01%
==========================================
Files 554 554
Lines 55646 55691 +45
==========================================
+ Hits 53405 53447 +42
- Misses 2241 2244 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Supports transforming
ExperimentDatawithMetadataToFloat&MapKeyToFloattransforms. The transform constructor is also updated to support extracting the observations for the relevant parameters fromexperiment_data.For
MapKeyToFloat, the actual transform is no-op, since we have the map keys inobservation_dataand we can simply extract them from there inAdapter.Background: As part of the larger refactor, we will be using
ExperimentDatain place oflist[Observation]within theAdapter.ExperimentData. Theobservationsinput to the constructors may be deprecated once the use cases are updated.Adapterwill be represented withExperimentDataand will be transformed usingtransform_experiment_data.Adapterand other methods, theObservation / ObservationFeatures / ObservationDataobjects will remain. To support these, we will retain the existing transform methods that service these objects.ExperimentDatais not planned to be used as an output of user facing methods, we do not need to untransform it. We are not planning to implementuntransform_experiment_data.Reviewed By: ltiao
Differential Revision: D76627256