Skip to content

Conversation

@ptondereau
Copy link
Member

@ptondereau ptondereau commented Oct 19, 2025

Description

  • We're adding a Docker build specific to musl, as the embedded PHP lib also needs to be compiled for musl, and the official images only have embedded SAPI for ZTS Alpine.
  • Rust doctests are disabled because rustdoc --test has its own compilation pipeline that overrides some flags with -static-pie
  • We're also re-exporting the runtime and static features for the whole project.
  • embed tests are disabled for now.

Note: The Dockerfile could be improved by a lot. I did my job here, as I'm not a Docker expert. 😅

@coveralls
Copy link

coveralls commented Oct 19, 2025

Pull Request Test Coverage Report for Build 18750142719

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 27.709%

Totals Coverage Status
Change from base Build 18747498499: 0.0%
Covered Lines: 1156
Relevant Lines: 4172

💛 - Coveralls

@ptondereau ptondereau force-pushed the ci/musl branch 2 times, most recently from bb0d4bb to 57911a4 Compare October 19, 2025 20:30
@ptondereau ptondereau linked an issue Oct 19, 2025 that may be closed by this pull request
@ptondereau ptondereau force-pushed the ci/musl branch 4 times, most recently from 8b62a14 to bf16f1d Compare October 20, 2025 09:39
@ptondereau ptondereau marked this pull request as ready for review October 20, 2025 09:55
@ptondereau ptondereau requested a review from Xenira October 20, 2025 10:12
@ptondereau ptondereau force-pushed the ci/musl branch 6 times, most recently from 6c00252 to 5978837 Compare October 23, 2025 13:33
@ptondereau ptondereau changed the title ci: add musl build step Add musl support Oct 23, 2025
@ptondereau ptondereau marked this pull request as draft October 28, 2025 15:46
@ptondereau
Copy link
Member Author

waiting #566 to be merged first

@ptondereau ptondereau force-pushed the ci/musl branch 2 times, most recently from 16b6f29 to 0571c43 Compare October 29, 2025 13:33
@coveralls
Copy link

coveralls commented Oct 29, 2025

Pull Request Test Coverage Report for Build 18953735590

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 31.098%

Totals Coverage Status
Change from base Build 18953724839: 0.0%
Covered Lines: 1359
Relevant Lines: 4370

💛 - Coveralls

@ptondereau ptondereau changed the title Add musl support feat: Add musl support Oct 29, 2025
@ptondereau ptondereau force-pushed the ci/musl branch 6 times, most recently from f4c4a6e to 6cdfe59 Compare October 29, 2025 14:54
@ptondereau ptondereau force-pushed the ci/musl branch 26 times, most recently from 502538d to a664a76 Compare October 30, 2025 19:48
@ptondereau ptondereau marked this pull request as ready for review October 30, 2025 20:20
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the advantage of downloading the release file over uaing git. Seems more complicated for the same result.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

git is basically slower at downloading even if it's backed by Microsoft.
You also skip ./buildconf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support for musl

4 participants