-
-
Notifications
You must be signed in to change notification settings - Fork 79
feat: Add musl support #561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Pull Request Test Coverage Report for Build 18750142719Details
💛 - Coveralls |
bb0d4bb to
57911a4
Compare
8b62a14 to
bf16f1d
Compare
6c00252 to
5978837
Compare
|
waiting #566 to be merged first |
16b6f29 to
0571c43
Compare
Pull Request Test Coverage Report for Build 18953735590Details
💛 - Coveralls |
f4c4a6e to
6cdfe59
Compare
502538d to
a664a76
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the advantage of downloading the release file over uaing git. Seems more complicated for the same result.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
git is basically slower at downloading even if it's backed by Microsoft.
You also skip ./buildconf
Description
rustdoc --testhas its own compilation pipeline that overrides some flags with-static-pieruntimeandstaticfeatures for the whole project.embedtests are disabled for now.Note: The Dockerfile could be improved by a lot. I did my job here, as I'm not a Docker expert. 😅