Skip to content

Conversation

@Xenira
Copy link
Member

@Xenira Xenira commented Apr 5, 2025

BREAKING CHANGE: Attributes like #[prop], #[rename], etc. have been moved to #[php] attributes like #[php(prop)], have been moved to #[php] attributes like #[php(prop)], #[php(name = "Foo")], #[php(rename = CamelCase)], etc.

Refs: #391

@Xenira Xenira linked an issue Apr 5, 2025 that may be closed by this pull request
@Xenira Xenira force-pushed the 391-consider-changing-prop-and-rename-macro-names branch from 22f6990 to 2c1a5f3 Compare April 5, 2025 17:52
@Xenira Xenira self-assigned this Apr 5, 2025
@Xenira Xenira added the macros Related to macros label Apr 5, 2025
@Xenira Xenira added this to the macro rework milestone Apr 5, 2025
@Xenira Xenira force-pushed the 391-consider-changing-prop-and-rename-macro-names branch 2 times, most recently from d899261 to 705aa20 Compare April 6, 2025 07:50
Xenira added 3 commits April 6, 2025 09:51
BREAKING CHANGE: Attributes like `#[prop]`, `#[rename]`, etc. have been moved to `#[php]` attributes like `#[php(prop)]`,  have been moved to `#[php]` attributes like `#[php(prop)]`, `#[php(name = "Foo")]`, `#[php(rename = CamelCase)]`, etc.

Refs: #391
@Xenira Xenira force-pushed the 391-consider-changing-prop-and-rename-macro-names branch from 705aa20 to 94f471d Compare April 6, 2025 07:51
@Xenira Xenira merged commit 90dfe33 into master Apr 6, 2025
33 of 35 checks passed
@Xenira Xenira mentioned this pull request Apr 6, 2025
@Xenira Xenira deleted the 391-consider-changing-prop-and-rename-macro-names branch May 5, 2025 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

macros Related to macros

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Consider changing #[prop] and #[rename] 'macro' names

2 participants