Try tests with Cstring

[joehoyle]

No description provided.

[danog]

Super strange that this is passing, it's very clear that the type should be a zend_string, not a C string...
https://github.com/php/php-src/blob/PHP-8.2/Zend/zend_compile.c#L6327

[joehoyle]

I think they are converted to ZendStr when copied from ZendFunctionEntry maybe? Looking at the macros for registering functions return types for internal functions, I can't see anything that expects a ZendStr there (ZEND_BEGIN_ARG_WITH_RETURN_OBJ_INFO -> ZEND_TYPE_INIT_CLASS)

[danog]

Ahh there's another _ZEND_TYPE_LITERAL_NAME_BIT flag, used to signify that type.ptr is not a zend_string* but a const char*

[joehoyle]

Ahhh! Nice find :D

[danog]

But we're using _ZEND_TYPE_NAME_BIT, not _ZEND_TYPE_LITERAL_NAME_BIT...

[joehoyle]

I think this might be different across PHP versions.. or something. IN PHP 8.3, there is:

/* Only one of these bits may be set. */
#define _ZEND_TYPE_NAME_BIT (1u << 24)
// Used to signify that type.ptr is not a `zend_string*` but a `const char*`,
#define _ZEND_TYPE_LITERAL_NAME_BIT (1u << 23)

whereas PHP 8.0:

#define _ZEND_TYPE_NAME_BIT (1u << 23)