[eas-cli] fix README.md command files URLs
#2318
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
URLs to our command source files are broken in README.
@gabimoncha caught it in #2317
Instead of pointing to
packages/eas-cli/src/commands/xyzURLs point tosrc/commands/xyz(incorrect, nonexistent location)Example: https://github.com/expo/eas-cli/blob/main/packages/eas-cli/README.md#eas-accountlogin
How
Since our
READMEgeneration process is automated by the oclif tool we should fix thepatch-readmescript we have to actually do its job and patchREADMEcorrectly and changesrc/commandstopackage/eas-cli/src/commands. TheREADMEgeneration process is run every time we do a new release.eas-cli/packages/eas-cli/package.json
Line 218 in dbb070f
Test Plan
Test locally by running
yarn versioninpackages/eas-clidir and inspecting the generatedREADME.Do a new release after merging it to see that it works on
main.