[ENG-11445] Add '--verbose-fastlane' flag for verbose fastlane logs

CHANGELOG.md

@@ -10,6 +10,8 @@ This is the log of notable changes to EAS CLI and related packages.
 
 - Generate metadata file for project archive ([#2149](https://github.com/expo/eas-cli/pull/2149) by [@khamilowicz](https://github.com/khamilowicz))
 
+- Add --verbose-fastlane flag to eas submit command for more robust fastlane pilot logs. ([#2276](https://github.com/expo/eas-cli/pull/2276) by [@khamilowicz](https://github.com/khamilowicz))
+
 - Add `eas credentials:configure-build` subcommand.
   ([#2282](https://github.com/expo/eas-cli/pull/2282) by [@fiberjw](https://github.com/fiberjw))
 

packages/eas-cli/src/build/runBuildAndSubmit.ts

@@ -437,6 +437,7 @@ async function prepareAndStartSubmissionAsync({
     projectId: buildCtx.projectId,
     exp: buildCtx.exp,
     vcsClient: buildCtx.vcsClient,
+    isVerboseFastlaneEnabled: false,
   });
 
   if (moreBuilds) {

packages/eas-cli/src/commands/submit.ts

@@ -33,6 +33,7 @@ interface RawCommandFlags {
   verbose: boolean;
   wait: boolean;
   'non-interactive': boolean;
+  'verbose-fastlane': boolean;
 }
 
 interface CommandFlags {
@@ -42,6 +43,7 @@ interface CommandFlags {
   verbose: boolean;
   wait: boolean;
   nonInteractive: boolean;
+  isVerboseFastlaneEnabled: boolean;
 }
 
 export default class Submit extends EasCommand {
@@ -83,6 +85,10 @@ export default class Submit extends EasCommand {
       default: true,
       allowNo: true,
     }),
+    'verbose-fastlane': Flags.boolean({
+      default: false,
+      description: 'Enable verbose logging for the submission process',
+    }),
     'non-interactive': Flags.boolean({
       default: false,
       description: 'Run command in non-interactive mode',
@@ -132,6 +138,7 @@ export default class Submit extends EasCommand {
         profile: submissionProfile.profile,
         archiveFlags: flagsWithPlatform.archiveFlags,
         nonInteractive: flagsWithPlatform.nonInteractive,
+        isVerboseFastlaneEnabled: flagsWithPlatform.isVerboseFastlaneEnabled,
         actor,
         graphqlClient,
         analytics,
@@ -175,6 +182,7 @@ export default class Submit extends EasCommand {
       wait,
       profile,
       'non-interactive': nonInteractive,
+      'verbose-fastlane': isVerboseFastlaneEnabled,
       ...archiveFlags
     } = flags;
 
@@ -195,6 +203,7 @@ export default class Submit extends EasCommand {
       wait,
       profile,
       nonInteractive,
+      isVerboseFastlaneEnabled,
     };
   }
 

packages/eas-cli/src/submit/android/AndroidSubmitter.ts

@@ -112,6 +112,7 @@ export default class AndroidSubmitter extends BaseSubmitter<
       changesNotSentForReview,
       releaseStatus,
       rollout,
+      isVerboseFastlaneEnabled: this.ctx.isVerboseFastlaneEnabled,
       ...serviceAccountKeyResult.result,
     };
   }

packages/eas-cli/src/submit/android/__tests__/AndroidSubmitCommand-test.ts

@@ -123,6 +123,7 @@ describe(AndroidSubmitCommand, () => {
           changesNotSentForReview: false,
         },
         nonInteractive: true,
+        isVerboseFastlaneEnabled: false,
         actor: mockJester,
         graphqlClient,
         analytics,
@@ -159,6 +160,7 @@ describe(AndroidSubmitCommand, () => {
           changesNotSentForReview: false,
         },
         nonInteractive: false,
+        isVerboseFastlaneEnabled: false,
         actor: mockJester,
         graphqlClient,
         analytics,
@@ -178,6 +180,7 @@ describe(AndroidSubmitCommand, () => {
           releaseStatus: SubmissionAndroidReleaseStatus.Draft,
           track: SubmissionAndroidTrack.Internal,
           changesNotSentForReview: false,
+          isVerboseFastlaneEnabled: false,
         },
       });
     });
@@ -203,6 +206,7 @@ describe(AndroidSubmitCommand, () => {
           changesNotSentForReview: false,
         },
         nonInteractive: false,
+        isVerboseFastlaneEnabled: false,
         actor: mockJester,
         graphqlClient,
         analytics,
@@ -222,6 +226,7 @@ describe(AndroidSubmitCommand, () => {
           releaseStatus: SubmissionAndroidReleaseStatus.InProgress,
           track: SubmissionAndroidTrack.Internal,
           changesNotSentForReview: false,
+          isVerboseFastlaneEnabled: false,
         },
       });
     });
@@ -250,6 +255,7 @@ describe(AndroidSubmitCommand, () => {
           changesNotSentForReview: false,
         },
         nonInteractive: false,
+        isVerboseFastlaneEnabled: false,
         actor: mockJester,
         graphqlClient,
         analytics,
@@ -267,6 +273,7 @@ describe(AndroidSubmitCommand, () => {
           releaseStatus: SubmissionAndroidReleaseStatus.Draft,
           track: SubmissionAndroidTrack.Internal,
           changesNotSentForReview: false,
+          isVerboseFastlaneEnabled: false,
         },
         submittedBuildId: fakeBuildFragment.id,
       });
@@ -312,6 +319,7 @@ describe(AndroidSubmitCommand, () => {
             changesNotSentForReview: false,
           },
           nonInteractive: false,
+          isVerboseFastlaneEnabled: false,
           actor: mockJester,
           graphqlClient,
           analytics,
@@ -334,6 +342,7 @@ describe(AndroidSubmitCommand, () => {
               track: SubmissionAndroidTrack.Beta,
               changesNotSentForReview: false,
               rollout: undefined,
+              isVerboseFastlaneEnabled: false,
             },
             submittedBuildId: selectedBuild.id,
           }
@@ -372,6 +381,7 @@ describe(AndroidSubmitCommand, () => {
             changesNotSentForReview: false,
           },
           nonInteractive: false,
+          isVerboseFastlaneEnabled: false,
           actor: mockJester,
           graphqlClient,
           analytics,
@@ -394,6 +404,7 @@ describe(AndroidSubmitCommand, () => {
               track: SubmissionAndroidTrack.Internal,
               changesNotSentForReview: false,
               rollout: undefined,
+              isVerboseFastlaneEnabled: false,
             },
             submittedBuildId: selectedBuild.id,
           }
@@ -439,6 +450,7 @@ describe(AndroidSubmitCommand, () => {
             changesNotSentForReview: false,
           },
           nonInteractive: false,
+          isVerboseFastlaneEnabled: false,
           actor: mockJester,
           graphqlClient,
           analytics,
@@ -462,6 +474,7 @@ describe(AndroidSubmitCommand, () => {
               track: SubmissionAndroidTrack.Internal,
               changesNotSentForReview: false,
               rollout: undefined,
+              isVerboseFastlaneEnabled: false,
             },
             submittedBuildId: selectedBuild.id,
           }

packages/eas-cli/src/submit/android/__tests__/ServiceAccountSource-test.ts

@@ -156,6 +156,7 @@ describe(getServiceAccountKeyResultAsync, () => {
         changesNotSentForReview: false,
       },
       nonInteractive: true,
+      isVerboseFastlaneEnabled: false,
       actor: mockJester,
       graphqlClient,
       analytics,
@@ -198,6 +199,7 @@ describe(getServiceAccountKeyResultAsync, () => {
         changesNotSentForReview: false,
       },
       nonInteractive: true,
+      isVerboseFastlaneEnabled: false,
       actor: mockJester,
       graphqlClient,
       analytics,
@@ -236,6 +238,7 @@ describe(getServiceAccountKeyResultAsync, () => {
         changesNotSentForReview: false,
       },
       nonInteractive: true,
+      isVerboseFastlaneEnabled: false,
       actor: mockJester,
       graphqlClient,
       analytics,

packages/eas-cli/src/submit/context.ts

@@ -21,6 +21,7 @@ export interface SubmissionContext<T extends Platform> {
   analyticsEventProperties: AnalyticsEventProperties;
   exp: ExpoConfig;
   nonInteractive: boolean;
+  isVerboseFastlaneEnabled: boolean;
   platform: T;
   profile: SubmitProfile<T>;
   projectDir: string;
@@ -46,6 +47,7 @@ export async function createSubmissionContextAsync<T extends Platform>(params: {
   credentialsCtx?: CredentialsContext;
   env?: Record<string, string>;
   nonInteractive: boolean;
+  isVerboseFastlaneEnabled: boolean;
   platform: T;
   profile: SubmitProfile<T>;
   projectDir: string;

packages/eas-cli/src/submit/ios/IosSubmitter.ts

@@ -32,6 +32,7 @@ export interface IosSubmissionOptions
   archiveSource: ArchiveSource;
   appSpecificPasswordSource?: AppSpecificPasswordSource;
   ascApiKeySource?: AscApiKeySource;
+  isVerboseFastlaneEnabled?: boolean;
 }
 
 interface ResolvedSourceOptions {
@@ -124,9 +125,11 @@ export default class IosSubmitter extends BaseSubmitter<
   ): IosSubmissionConfigInput {
     const { appSpecificPassword, ascApiKeyResult } = credentials;
     const { appleIdUsername, ascAppIdentifier } = options;
+    const { isVerboseFastlaneEnabled } = this.ctx;
     return {
       ascAppIdentifier,
       appleIdUsername,
+      isVerboseFastlaneEnabled,
       ...(appSpecificPassword ? this.formatAppSpecificPassword(appSpecificPassword) : null),
       ...(ascApiKeyResult?.result ? this.formatAscApiKeyResult(ascApiKeyResult.result) : null),
     };

packages/eas-cli/src/submit/ios/__tests__/AscApiKeySource-test.ts

@@ -57,6 +57,7 @@ async function getIosSubmissionContextAsync(): Promise<SubmissionContext<Platfor
       language: 'en-US',
     },
     nonInteractive: true,
+    isVerboseFastlaneEnabled: false,
     actor: mockJester,
     graphqlClient,
     analytics,
@@ -249,6 +250,7 @@ describe(getAscApiKeyResultAsync, () => {
         language: 'en-US',
       },
       nonInteractive: true,
+      isVerboseFastlaneEnabled: false,
       actor: mockJester,
       graphqlClient,
       analytics,

packages/eas-cli/src/submit/ios/__tests__/IosSubmitCommand-test.ts

@@ -100,6 +100,7 @@ describe(IosSubmitCommand, () => {
         ascAppId: '12345678',
       },
       nonInteractive: false,
+      isVerboseFastlaneEnabled: false,
       actor: mockJester,
       graphqlClient,
       analytics,
@@ -134,6 +135,7 @@ describe(IosSubmitCommand, () => {
           language: 'en-US',
         },
         nonInteractive: true,
+        isVerboseFastlaneEnabled: false,
         actor: mockJester,
         graphqlClient,
         analytics,
@@ -169,6 +171,7 @@ describe(IosSubmitCommand, () => {
           ascAppId: '12345678',
         },
         nonInteractive: false,
+        isVerboseFastlaneEnabled: false,
         actor: mockJester,
         graphqlClient,
         analytics,
@@ -186,7 +189,9 @@ describe(IosSubmitCommand, () => {
           appleIdUsername: '[email protected]',
           appleAppSpecificPassword: 'abcd-abcd-abcd-abcd',
           ascAppIdentifier: '12345678',
+          isVerboseFastlaneEnabled: false,
         },
+        submittedBuildId: undefined,
       });
 
       delete process.env.EXPO_APPLE_APP_SPECIFIC_PASSWORD;
@@ -231,6 +236,7 @@ describe(IosSubmitCommand, () => {
             ascAppId: '12345678',
           },
           nonInteractive: false,
+          isVerboseFastlaneEnabled: false,
           actor: mockJester,
           graphqlClient,
           analytics,
@@ -248,6 +254,7 @@ describe(IosSubmitCommand, () => {
             appleIdUsername: '[email protected]',
             appleAppSpecificPassword: 'abcd-abcd-abcd-abcd',
             ascAppIdentifier: '87654321',
+            isVerboseFastlaneEnabled: false,
           },
           archiveSource: undefined,
         });
@@ -288,6 +295,7 @@ describe(IosSubmitCommand, () => {
             ascAppId: '12345678',
           },
           nonInteractive: false,
+          isVerboseFastlaneEnabled: false,
           actor: mockJester,
           graphqlClient,
           analytics,
@@ -305,6 +313,7 @@ describe(IosSubmitCommand, () => {
             appleIdUsername: '[email protected]',
             appleAppSpecificPassword: 'abcd-abcd-abcd-abcd',
             ascAppIdentifier: '12345678',
+            isVerboseFastlaneEnabled: false,
           },
           archiveSource: undefined,
         });
@@ -350,6 +359,7 @@ describe(IosSubmitCommand, () => {
             ascAppId: '12345678',
           },
           nonInteractive: false,
+          isVerboseFastlaneEnabled: false,
           actor: mockJester,
           graphqlClient,
           analytics,
@@ -368,6 +378,7 @@ describe(IosSubmitCommand, () => {
             appleIdUsername: '[email protected]',
             appleAppSpecificPassword: 'abcd-abcd-abcd-abcd',
             ascAppIdentifier: '12345678',
+            isVerboseFastlaneEnabled: false,
           },
           archiveSource: undefined,
         });