[build-tools] Pass through workflow from job to expo-updates CLI commands #384
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wschurman
commented
Apr 24, 2024
| ? { | ||
| extraEnv: { | ||
| EXPO_UPDATES_FINGERPRINT_OVERRIDE: resolvedExpoUpdatesRuntimeVersion, | ||
| EXPO_UPDATES_WORKFLOW_OVERRIDE: ctx.job.type, |
There was a problem hiding this comment.
this isn't technically needed since this is only used if EXPO_UPDATES_FINGERPRINT_OVERRIDE isn't provided, but worth adding for consistency just in case someone puts up a project that uses it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
eas-buildchange corresponding to expo/expo#28403, which allows passing the workflow through from the job. This is necessary in EAS Build since it does prebuild, and workflow auto-detection in expo-updates depends on the presence of native directories or lack thereof, as well as their gitignore status.Because our default gitignore doesn't ignore the native directories, prebuilt will make the detection code think it's a generic workflow.
How
Pass workflow through. Note that in this library, there's a third workflow enum "UNKNOWN", which if passed through to the expo-updates CLIs will throw. This is on purpose as we shouldn't be running those CLIs for jobs where the workflow is unknown. Note that eas-cli only ever generates generic or managed when constructing a normal build job (the only type of job where these are run).
Test Plan
Follow test plan of expo/expo#28403 to create the project, then run the following to ensure runtime version resolution works with new arg:
~/expo/run-with-local-eas-build.sh build --local