Rewrite test result message #92
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| SET message = 'Result for ' || tests.task || ' ' || tests.item || ' ' || tests.score || ' is ' || actual.result || ', but should be ' || tests.expected | ||
| SET message = ( | ||
| 'Result for ' || tests.task || ' ' || tests.item || ' ' || tests.score | ||
| || ' is <' || CASE WHEN actual.result IS NULL THEN "NULL" ELSE actual.result END |
There was a problem hiding this comment.
Suggested change
| || ' is <' || CASE WHEN actual.result IS NULL THEN "NULL" ELSE actual.result END | |
| || ' is <' || COALESCE(actual.result, "NULL") |
There was a problem hiding this comment.
This is the canonical way IIRC.
There was a problem hiding this comment.
Thank you for showing us the way! PR updated.
vaeng
approved these changes
May 21, 2025
SleeplessByte
approved these changes
May 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.