Skip to content

Update instructions to match tests and function signature. #2089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

ColinPitrat
Copy link
Contributor

Tests are verifying that the function works with i64::MAX and u64::MAX so it needs to go beyond 999_999_999_999.

The function signature takes a u64 so saying to test with -1 doesn't make sense.

https://forum.exercism.org/t/say-instructions-are-inconsistent-with-test/18695

Tests are verifying that the function works with i64::MAX and u64::MAX
so it needs to go beyond 999_999_999_999.

The function signature takes a u64 so saying to test with -1 doesn't make
sense.

https://forum.exercism.org/t/say-instructions-are-inconsistent-with-test/18695
Copy link
Contributor

github-actions bot commented Aug 4, 2025

Hello. Thanks for opening a PR on Exercism 🙂

We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in.

You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch.

If you're interested in learning more about this auto-responder, please read this blog post.


Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.

@github-actions github-actions bot closed this Aug 4, 2025
@SleeplessByte SleeplessByte reopened this Aug 4, 2025
Copy link
Member

@SleeplessByte SleeplessByte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned on the forum, the instructions for this particular exercise should not be added or changes directly. @senekor has given the approval for this PR to exist to be considered if it instead changes (adds) instructions.append.md (docs).

Thank you for working on this!

@ColinPitrat
Copy link
Contributor Author

Ah, there's already an instructions.append.md and indeed, it does display at the end of the instructions:

Extension
Add capability of converting up to the max value for u64: 18_446_744_073_709_551_615.
For hints at the output this should have, look at the last test case.

Somehow I missed it. So no further change is needed I guess.

@ColinPitrat ColinPitrat closed this Aug 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants