Skip to content

Ensure problem-specifications is symlinked #2072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 26, 2025
Merged

Conversation

senekor
Copy link
Contributor

@senekor senekor commented Jun 25, 2025

This is especially relevant for the add-exercise workflow, which will suggest slugs of unimplemented exercises from problem-specifications only if the symlink exists. Otherwise no suggestions are made without any hint that something went wrong.

This is especially relevant for the add-exercise workflow, which will
suggest slugs of unimplemented exercises from problem-specifications
only if the symlink exists. Otherwise no suggestions are made without
any hint that something went wrong.
@senekor senekor requested a review from ellnix June 25, 2025 17:48
Copy link
Contributor

@ellnix ellnix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I don't see the reason for the
-L check (script seems to work fine anyway and might have the added benefit of ensuring that problem-specifications are on the correct commit), but there's probably an edge case I'm not thinking of.

@senekor
Copy link
Contributor Author

senekor commented Jun 26, 2025

The idea is that maybe you're testing some other commit, maybe you have some local changes in problem-specifications that you want to test how they interact with the Rust track. It would be annoying if running these scripts messed with those changes. So, only run the script if the symlink doesn't exist already.

@senekor senekor merged commit 1f9f9ed into main Jun 26, 2025
12 checks passed
@senekor senekor deleted the senekor-ommuzwosnxwu branch June 26, 2025 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants