Maintenance for Rubocop

[kotp]

• Deprecated option --auto-correct is currently used for bin/rubocop-quick
• • use --autocorrect instead of --auto-correct
• Discuss changing enforced style around access modifiers to around rather than only before

[kotp]

To clarify, without the only_before the around is default, so we can remove that directive, or change the directive using the default value and explicitly state it is the style we have chosen.

If anyone has a reason they can articulate as to why we should prefer "only_before" as the option, let me know.

The argument for "around" is that private is a method, and accepts optional arguments. If there is (probably unintended) escaping of the newline, then the symbol resulting from the definition of the following method would cause only that following method to be private. This could be a potentially hard to spot bug, if it is unintentional.

Syntactically, then:

private \
def something
end

means:

private :something

And that is perhaps unclear, especially if you do not know, but also potentially hard to detect that it was not wanted, until it becomes a bug because something was not private that was meant to be. (This is, however, true as well for the other access modifiers, to list them, protected and public.)

With the blank space around, then you would get notification of this, since the escape would make it so that there is no blank line after, if there is an accidental escaped newline.

Better communication, less accidental semantics, so in my opinion, the better way to go.