-
-
Notifications
You must be signed in to change notification settings - Fork 28
Added Collatz conjecture exericse #369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hello. Thanks for opening a PR on Exercism 🙂 We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in. You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch. If you're interested in learning more about this auto-responder, please read this blog post. Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it. |
Hello 👋 Thanks for your PR. This repo does not currently have dedicated maintainers. Our cross-track maintainers team will attempt to review and merge your PR, but it will likely take longer for your PR to be reviewed. If you enjoy contributing to Exercism and have a track-record of doing so successfully, you might like to become an Exercism maintainer for this track. Please feel free to ask any questions, or chat to us about anything to do with this PR or the reviewing process on the Exercism forum. (cc @exercism/cross-track-maintainers) |
This is an unmaintained repository. Cross-track maintainers - feel free to merge. |
I just noticed the CI failure. I will look into that now. |
test("large number of even and odd steps", () => | ||
expect(collatzConjecture(1000000)) |> toEqual(Ok(152)) | ||
); | ||
test("zero is and error", () => |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo: "and" => "an"
Typo in test fixed. I believe this is good to go. |
The merge conflict for the track config needs to be resolved. Generally, when I plan to add multiple exercises in a short timeframe, I move each new exercise from the bottom to somewhere else in the list of exercises. That way the new entries don’t conflict with each other. |
That's a great tip. I will fix this within the hour |
Collatz conjecture added to track.
This also gave me a good chance to thoroughly test the exercise creation workflow, in order to update the docs in a future PR.