Skip to content

First concept exercise, 4th task: compare JSON objects without ordered keys #289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 6, 2025

Conversation

glennj
Copy link
Contributor

@glennj glennj commented Aug 5, 2025

See http://forum.exercism.org/t/shopping-list-exercise-trouble-in-task-4/18714

I'm adding the custom assert functions we use in various exercises to the bats-jq.bash script all exercises use. But I'm not deploying this to all exercises (yet).

This should probably be "no important files changed" to not affect existing solutions.

Copy link
Contributor

github-actions bot commented Aug 5, 2025

This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.

If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.

[no important files changed]

For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin in a comment. Thank you!

@glennj glennj requested a review from a team August 5, 2025 20:20
@@ -27,3 +26,64 @@ jq() {
echo "$output"
return "$rc"
}

#############################################################
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we be updating all the exercises with the new bats-jq file?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll do that in a separate PR, to keep this one in focus

@glennj glennj merged commit 32d24ff into exercism:main Aug 6, 2025
4 checks passed
@glennj glennj deleted the shopping-asserts branch August 6, 2025 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants