-
-
Notifications
You must be signed in to change notification settings - Fork 30
upgrade to jq 1.8.0 #283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade to jq 1.8.0 #283
Conversation
@IsaacG I had neglected to update docs. |
docs/INSTALLATION.md
Outdated
This is the version used in the online jq test runner. | ||
|
||
Most Linux package managers will install the previous release, version 1.6. | ||
Many Linux package managers will install an older release, version 1.6. | ||
It's worth installing the newer version: there were [substantial changes in the 1.7 release][release-notes-1.7]. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this line need updating, too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I kept that because that's when the source code was transferred to the jqlang org, so big changes did happen then.
I suppose I don't need to keep it: people can go find the release notes if they are curious.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could also drop the version in the prior line. Something like this?
Many Linux package managers will install an older release.
You may want to consider using a version newer than what your package manager installs by default.
In particular, there were [substantial changes in the 1.7 release][release-notes-1.7].
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it make sense to have a single "version" doc and have the other docs reference that, only hard coding versions in one place?
It would be nice if there was a way to use a template/variables in these docs 😁
I take another round, to see if I can reduce the number of occurrences. |
This latest commit removes the version number from all but the Installation and Tests docs. A later effort will be to revisit the concepts, to see if there's any relevant breaking changes. |
Co-authored-by: Isaac Good <[email protected]>
Summary
To align with #jq-test-runner/47 that updates the test runner to jq 1.8.0, let's do the same here.
Exercise tests running successfully with the new jq version on my machine.
Checklist
./bin/fetch-configlet && ./bin/configlet generate
to ensure all documents are properly generated.