Skip to content

Fix StateOfTicTacToe tests #1323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 4, 2025
Merged

Fix StateOfTicTacToe tests #1323

merged 2 commits into from
Aug 4, 2025

Conversation

Sprootch
Copy link
Contributor

@Sprootch Sprootch commented Aug 1, 2025

Typo in gamestate instead of gameState.

Copy link
Contributor

github-actions bot commented Aug 1, 2025

Hello. Thanks for opening a PR on Exercism 🙂

We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in.

You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch.

If you're interested in learning more about this auto-responder, please read this blog post.


Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.

@github-actions github-actions bot closed this Aug 1, 2025
Copy link
Contributor

github-actions bot commented Aug 1, 2025

This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.

If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.

[no important files changed]

For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin in a comment. Thank you!

@ErikSchierboom ErikSchierboom reopened this Aug 4, 2025
@ErikSchierboom
Copy link
Member

Normally I'd not merge this due to it breaking the existing solutions, but as there are so few, it's okay in this case. You do also need to update this file: https://github.com/Sprootch/exercism-fsharp-pr/blob/18517e8423365cbf37b3bd97b41ca9ec78a76aed/exercises/practice/state-of-tic-tac-toe/.meta/Example.fs#L26

gamestate -> gameState
@Sprootch
Copy link
Contributor Author

Sprootch commented Aug 4, 2025

Done ;)

@ErikSchierboom ErikSchierboom merged commit 77e17ad into exercism:main Aug 4, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants