Skip to content

Fix defaultRowHeight not working #855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 13, 2019
Merged

Fix defaultRowHeight not working #855

merged 2 commits into from
Jun 13, 2019

Conversation

autukill
Copy link
Contributor

guyonroche
guyonroche requested changes Jun 11, 2019
View reviewed changes
lib/xlsx/xform/sheet/sheet-format-properties-xform.js
@@ -13,6 +13,7 @@ class SheetFormatPropertiesXform extends BaseXform {
outlineLevelRow: model.outlineLevelRow,
outlineLevelCol: model.outlineLevelCol,
'x14ac:dyDescent': model.dyDescent,
customHeight: model.defaultRowHeight === 0 ? '0' : '1',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you fix the unit tests that have failed due to this change

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

@guyonroche guyonroche merged commit 839c7f5 into exceljs:master Jun 13, 2019
@autukill autukill deleted the master branch June 15, 2019 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guyonroche guyonroche guyonroche approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@autukill @guyonroche @Alanscut