CHORE: Update @wordpress/scripts and @wordpress/jest-preset-default to latest #1045
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- also removes redundant `@wordpress/eslint-plugin which is included with @wordpress/scripts
- We use our own format for import commenting
Contributor
Author
|
I'm going to close this pull in favor of the dependabot auto updates that I've been handling. More granular updates mean for a bit easier resolution of issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull
@wordpress/scriptsto the latest version which includes a number of changes (including new linting rules, updating jest, etc).@wordpress/es-lintdependency (because that's a part of the updated@wordpress/scriptspackage.@wordpress/jest-preset-defaultpackage to latest (for parity with jest updates).Currently this is a WIP and on hold because there's a bug in the Jest version included with this update (Jest 24.1) that causes a couple of our tests to fail because of our dependency on moduleMapping for our internal package like things. The bug is fixed here.
I'll have to monitor when the new version of Jest is released with that fix and then do a pull for
@wordpress/scriptsto get that change.This isn't a critical update but it does bring some helpful new lint rules/tools so it'd be nice to update to it when possible.