Skip to content

Conversation

lsfera
Copy link

@lsfera lsfera commented May 9, 2024

Split pub sub
tests on compose
Wrapped subscriptionoptions to expose via library

Copy link
Collaborator

@oskardudycz oskardudycz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added smaller comments and suggestions, but in overall that looks great. Such PRs make me love OSS again 😅

Could you also check the docker-compose config as the pipeline is failing?

@oskardudycz
Copy link
Collaborator

@lsfera, thank you a lot for your hard work on that; I'm merging it as it is and creating the dedicated issues based on our conversations.

I'll probably go ahead and prepare the package to be released. My code name is Benjamin Blümchen 😅

I'll also probably transfer the repository to the event-driven.io organisation for better housekeeping.

@oskardudycz
Copy link
Collaborator

@lsfera now it's here, if you're looking for it https://github.com/event-driven-io/Blumchen (just housekeeping, no changes to licensing etc.).

@oskardudycz
Copy link
Collaborator

@lsfera and here it is version 0.0.1 https://www.nuget.org/packages/Blumchen/ 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants