Getting settled, some things that I saw so far

[wzrdtales]

Foreword

Hey there, I'm getting an overview currently and alredy see where things are going in the wrong direction currently. I hope I can clear up your confusion.

Questions

• Would a docker-compose file not be more suited than a Dockerfile? A Dockerfile is mostly to build the docker container for the current project. I think that could be confusing.
• Which timezone are you living in? Want to know when I can best communicate with you.

Refs

Refers to db-migrate/node-db-migrate#380

[wzrdtales]

Btw. would be awesome if you can give feedback afterwards what you're missing on the docs or even help to make them better. Already giving me feedback what you expect to be delivered to you would help tremendously.

[wzrdtales]

Another thing, how do you require your driver currently? It does not seem that you have something in place yet to parse the es6 code?

[moxious]

The es6 code works via babel, in the gulp compile target. It gets translated to es5 in the dist folder, note that package.json refers to the compiled dist/index.js

[moxious]

I'm in the EST timezone (GMT-5).

On Docker -- well actually I may split this out later and reuse a different project I have (https://github.com/moxious/couchbase-docker-circleci) that has an easy docker container, and then just pull that from circleci and run it. This code got started before that project was there.

The circleci / docker bits already work great; the tricky part is then how to test.

Yes, I can provide feedback on the documentation. I read the entire section on how to contribute, mostly that was pretty good, but of course very skewed towards relational databases. In the NoSQL part, really what's meant is just mongoDB. So the docs didn't cover my case but that wasn't really to be expected. The biggest missing part in the docs for me has to do with the question I already asked -- how to add functions to my driver and use them that don't correspond to the regular MigratorInterface.

One other bit about docs - one of your recent links showed me where to look, but it's quite difficult for people reading the source if your tests for your drivers are in a different place than the drivers themselves. I had been assuming you had no unit tests or integration tests in place for the drivers, because I went and looked at the driver code and there was nothing there. When in fact the tests are still in the main package.

[wzrdtales]

yeah you do not have any routines in your project yet I did it actually manually.

actually it throws errors yet

[INFO] loading migrations from database
[2016-06-21T18:24:57.571Z]  INFO: db-migrate-couchbase/16610 on tobi: allLoadedMigrations
[2016-06-21T18:24:57.790Z]  INFO: db-migrate-couchbase/16610 on tobi: Close
[ERROR] Error: No primary index on keyspace default. Use CREATE PRIMARY INDEX to create one.

I don't know how far you are in development currently, you're probably quite still in setting the project up?

[moxious]

This "No primary index" issue has to do with Ottoman, it's easily patched. I'm actually well past this point because I'm working on other DBs, you just have an empty one. :) I will push a fix for that momentarily.

[wzrdtales]

When in fact the tests are still in the main package.

Yes, that is due to the fact, that first with v0.10.x drivers have been moved out, but tests did not yet. That has several reasons, one being that I'm really into doing so much stuff actually (and actually nearly the whole last year though) that I did not yet got into rewriting all tests.

B/c just porting is not enough in this case, vows the used framework has several bugs, which makes it impossible to test some of those things that have been newly introduced. Thus I wanted and needed to switch. Have looked to switch to either mocha or lab. When this switch is being done, this would also include the step moving them away.

[wzrdtales]

Hit me up when you pushed something

[moxious]

Pushed. The fix for the issue you had is this: 98b2b6a#diff-168726dbe96b3ce427e7fedce31bb0bcR87

[moxious]

BTW -- this mocha testing approach isn't going to work, but this is how I'm attempting to go: https://github.com/etops/db-migrate-couchbase/blob/master/test/basic_spec.js#L6

[wzrdtales]

you should update also the install yourself sh to actually compile the file ;)

[moxious]

I just pushed updates to not do docker build at all, to rely on an outside image I control. No more Dockerfile, init.sh.

Also updated install-yourself to run gulp compile, which was done as a separate step in circle.yml before.

[wzrdtales]

Just got this, I get your latest updates currently

[2016-06-21T18:42:23.966Z]  INFO: db-migrate-couchbase/20183 on tobi: Connecting to cluster { cluster: 'localhost:8091?detailed_errcodes=1' }
[2016-06-21T18:42:23.967Z]  INFO: db-migrate-couchbase/20183 on tobi: init
[ERROR] TypeError: First argument needs to be a ViewQuery, SpatialQuery or N1qlQuery.

[wzrdtales]

run-local still relies on couchtest, I doubt you have control about a _ docker image do you?

[moxious]

Install yourself is very tricky, sometimes even when I do this, db-migrate won't find the driver.

Just pushed a patch for run-local, I had missed that one.

Whether the docker image is built locally or pulled from somewhere else doesn't really matter, it's just a small sample image with a basic minimum config for testing.