Data race in storage.(*mockNetFetcher).Request()

[frncmx]

How to reproduce?

go test -race -count 1 -run TestNetStoreFetcherLifeCycleWithTimeout github.com/ethereum/go-ethereum/swarm/storage

Stacktrace

==================
WARNING: DATA RACE
Write at 0x00c00012a1f8 by goroutine 84:
  github.com/ethereum/go-ethereum/swarm/storage.(*mockNetFetcher).Request()
      /home/frncmx/code/src/github.com/ethereum/go-ethereum/swarm/storage/netstore_test.go:54 +0x56
  github.com/ethereum/go-ethereum/swarm/storage.(*fetcher).Fetch()
      /home/frncmx/code/src/github.com/ethereum/go-ethereum/swarm/storage/netstore.go:276 +0x5e8
  github.com/ethereum/go-ethereum/swarm/storage.(*fetcher).Fetch-fm()
      /home/frncmx/code/src/github.com/ethereum/go-ethereum/swarm/storage/netstore.go:155 +0x59
  github.com/ethereum/go-ethereum/swarm/storage.(*NetStore).FetchFunc.func1()
      /home/frncmx/code/src/github.com/ethereum/go-ethereum/swarm/storage/netstore.go:122 +0x50
  github.com/ethereum/go-ethereum/swarm/storage.TestNetStoreFetcherLifeCycleWithTimeout.func1()
      /home/frncmx/code/src/github.com/ethereum/go-ethereum/swarm/storage/netstore_test.go:654 +0xc6

Previous write at 0x00c00012a1f8 by goroutine 86:
  github.com/ethereum/go-ethereum/swarm/storage.(*mockNetFetcher).Request()
      /home/frncmx/code/src/github.com/ethereum/go-ethereum/swarm/storage/netstore_test.go:54 +0x56
  github.com/ethereum/go-ethereum/swarm/storage.(*fetcher).Fetch()
      /home/frncmx/code/src/github.com/ethereum/go-ethereum/swarm/storage/netstore.go:276 +0x5e8
  github.com/ethereum/go-ethereum/swarm/storage.(*fetcher).Fetch-fm()
      /home/frncmx/code/src/github.com/ethereum/go-ethereum/swarm/storage/netstore.go:155 +0x59
  github.com/ethereum/go-ethereum/swarm/storage.(*NetStore).FetchFunc.func1()
      /home/frncmx/code/src/github.com/ethereum/go-ethereum/swarm/storage/netstore.go:122 +0x50
  github.com/ethereum/go-ethereum/swarm/storage.TestNetStoreFetcherLifeCycleWithTimeout.func1()
      /home/frncmx/code/src/github.com/ethereum/go-ethereum/swarm/storage/netstore_test.go:654 +0xc6

[janos]

@zelig This is a different fetcher, the one in storage package, then that I worked on in network package #1121. I will have a look at this problem, but it is not solved by the PR.

[janos]

The fix for this issue is submitted here ethereum/go-ethereum#18462.