Skip to content
This repository was archived by the owner on Aug 2, 2021. It is now read-only.
This repository was archived by the owner on Aug 2, 2021. It is now read-only.

fix inconsistencies in POT iterators #1053

@zelig

Description

@zelig

FYI there seems to be bugs in the pot iterators. Fortunately, the buggy parts don't seem to be used by anything outside the package

  • Each and EachFrom return the "pinned" Val even though comment says they doen't
  • Each and EachFrom report the "pinned" Val as po = 0 instead of the correct po = 256
  • EachBin passes a po value to both its outer and inner iterator. The inner one seems to be unreliable.

All these POs are not well defined, i recommend we eliminate this argument from the iterator function

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions