client: Jwt token based auth for engine api enabled via rpcEngineAuth arg
#1751
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
looks great, thanks so much for doing and sticking through! can't believe you also got the ws auth working, that is very cool. we're just missing some coverage on the ws auth now, would you be able to add a few cases to the rpc.spec tests to get coverage on the lines? then I'll approve and merge in :) |
ryanio
reviewed
Feb 28, 2022
ryanio
reviewed
Feb 28, 2022
ryanio
approved these changes
Feb 28, 2022
thank you @ryanio ❤️, and thanks a ton for your edits/improvs/feedback 🙏 happy to contribute to ethereumjs! 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kiln spec v2 has jwt based auth for the engine json rpc requests through both http/websocket protocols. Following are some salient features of implementing same in this PR:
--jwt-secretparam to specify the file for jwt secret, in its absence a random 256 bit key is generated (and dumped in a file)--rpcEngineAuthparam addition to enable the above authentication mechanism, so that the requests remain backward compatible till all clients move to jwt authThis PR is a fresh pull in continuation to this previous PR #1723
cc: @ryanio