This repository was archived by the owner on Sep 8, 2025. It is now read-only.
[WIP] vm tracing #1531
Closed
[WIP] vm tracing #1531
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pipermerriam
force-pushed
the
piper/vm-tracing
branch
from
62b2f49 to
bdb0d50
Compare
carver
reviewed
Dec 11, 2018
| # Error handling | ||
| # | ||
| @property | ||
| def error(self) -> Optional[VMError]: |
There was a problem hiding this comment.
Maybe this error refactor could be split out
There was a problem hiding this comment.
cc @rayrapetyan though I will look into doing this myself tomorrow and you can rebase your branch.
|
closing as #1515 now contains these changes. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extension of #1515
What was wrong?
Need the ability to produce EVM trace output.
https://github.com/ethereum/go-ethereum/wiki/Tracing:-Introduction
How was it fixed?
Took what was started in #1515 and reworked to be more inline with the architecture of this codebase.
Cute Animal Picture