ethdb: refactor Database interface #30693
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MariusVanDerWijden
requested review from
holiman,
karalabe and
rjl493456442
as code owners
MariusVanDerWijden
force-pushed
the
cleanup-db-interface
branch
from
865598e to
2e812c6
Compare
rjl493456442
approved these changes
Oct 29, 2024
holiman
pushed a commit
that referenced
this pull request
Nov 19, 2024
This was referenced Dec 6, 2024
19 tasks
jakub-freebit
pushed a commit
to fblch/go-ethereum
that referenced
this pull request
Jul 3, 2025
gballet
pushed a commit
to gballet/go-ethereum
that referenced
this pull request
Sep 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This clears up the ethdb.Database interface, making it more understandable that it is basically just the AncientStore and KeyValueStore combined. Also removes a few interfaces that are not needed anymore, and makes a few types implement the
AncientStaterinterface