Skip to content

Conversation

@cyberhorsey
Copy link

@cyberhorsey cyberhorsey commented Jun 26, 2024

The implementation for this default gas price exists, but is actually unable to be set via a flag, because the flag was not created. This PR simply adds the flag and the context check if its set, and updates cfg.Default if so.

@cyberhorsey cyberhorsey changed the title cmd/flags: default gas price flag cmd/utils: default gas price flag Jun 26, 2024
@MariusVanDerWijden
Copy link
Member

@cyberhorsey what do you think about this: #30080
The default wasn't really used anywhere so we can just get rid of it.
It only really determines the start price of the oracle, so I don't think it needs to be configurable by the user.
Lemme know if I missed something

@cyberhorsey
Copy link
Author

@cyberhorsey what do you think about this: #30080 The default wasn't really used anywhere so we can just get rid of it. It only really determines the start price of the oracle, so I don't think it needs to be configurable by the user. Lemme know if I missed something

Can be fine as well, we actually use it at Taiko (and added this flag on our fork) when launching our chain and testnets, but we can just keep it on our fork if removing it is better here.

@fjl
Copy link
Contributor

fjl commented Jun 28, 2024

As @MariusVanDerWijden said, the flag only sets the starting price, and that price will start drifting as predictions are made. So configuring it is useless, because the config value doesn't stick.

@fjl fjl closed this Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants