params: clarify consensus engine config Strings
#29643
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
String()methods on a value receiever so that nil is shown differently.CliqueConfig.Currently these config objects will display the same whether they're nil or present. For example, this chain config:
{ "chainId": 1212, "homesteadBlock": 0, "eip150Block": 0, "eip155Block": 0, "eip158Block": 0, "byzantiumBlock": 0, "constantinopleBlock": 0, "petersburgBlock": 0, "istanbulBlock": 0, "berlinBlock": 0, "londonBlock": 0, "mergeNetsplitBlock": 0, "terminalTotalDifficulty": 0, "shanghaiTime": 0, "cancunTime": 0 }when printed with
%+v, shows as (noteEthash:ethash Clique:cliqueat the end):With this change, we see
Ethash:<nil> Clique:<nil>.If we add a
cliquekey to the config:{ "chainId": 1212, "homesteadBlock": 0, "eip150Block": 0, "eip155Block": 0, "eip158Block": 0, "byzantiumBlock": 0, "constantinopleBlock": 0, "petersburgBlock": 0, "istanbulBlock": 0, "berlinBlock": 0, "londonBlock": 0, "mergeNetsplitBlock": 0, "terminalTotalDifficulty": 0, "shanghaiTime": 0, "cancunTime": 0, "clique": { "period": 5, "epoch": 30000 } }and print it, it currently shows identically to the first one (
Ethash:ethash Clique:clique).With this change we see
Ethash:<nil> Clique:clique(period: 5, epoch: 30000).This makes it more clear which engines are and are not active.
This is revised from #29635.