core/rawdb: add logging and fix comments around AncientRange function. #28379
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakub-freebit
requested review from
holiman,
karalabe and
rjl493456442
as code owners
| } | ||
| // The data is on the order [h, h+1, .., n] -- reordering needed | ||
| for i := range data { | ||
| rlpHeaders = append(rlpHeaders, data[len(data)-1-i]) |
Member
There was a problem hiding this comment.
Can you elaborate what's the difference between the old and new logic?
In the old code, ancient headers are reordered/appended only if they are all loaded
In the new code, the logic is same?
Btw, I think we can use max=0 to un-specify the size limit. As function description says,
This method assumes that the caller already has placed a cap on count, to prevent DoS issues., we don't need to worry about the size overflow issue.
Contributor
Author
There was a problem hiding this comment.
Yes, I didn't change the logic, just added logging errors in case AncientRange fails and logging warnings in case AncientRange reads less than requested count.
Thank you for clarifying that it is ok to use max=0 here.
I will update the PR.
fjl
approved these changes
Oct 31, 2023
devopsbo3
pushed a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
ethereum#28379) This adds warning logs when the read does not match the expected count. We can also remove the size limit since the function documentation explicitly states that callers should limit the count.
devopsbo3
added a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
…function. (ethereum#28379)" This reverts commit f81a9f3.
devopsbo3
added a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
…function. (ethereum#28379)" This reverts commit f81a9f3.
Dergarcon
pushed a commit
to MetaMask/mev-geth-0x2mev
that referenced
this pull request
Jan 31, 2024
ethereum#28379) This adds warning logs when the read does not match the expected count. We can also remove the size limit since the function documentation explicitly states that callers should limit the count.
colinlyguo
pushed a commit
to scroll-tech/go-ethereum
that referenced
this pull request
Oct 31, 2024
ethereum#28379) This adds warning logs when the read does not match the expected count. We can also remove the size limit since the function documentation explicitly states that callers should limit the count.
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds logging and fixes some comments around the
AncientRangefunction. Addresses #27667.