Skip to content

graphql: don't allocate greedily #27873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 8, 2023
Merged

graphql: don't allocate greedily #27873

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
65d8fe0
graphql: don't allocate greedily
holiman Aug 7, 2023
8baa7f1
graphql: respect timeout in block resolver
holiman Aug 7, 2023
a05be5f
Update graphql/graphql.go
holiman Aug 7, 2023
9113aae
fix lint issue
s1na Aug 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion graphql/graphql.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1250,7 +1250,7 @@ func (r *Resolver) Blocks(ctx context.Context, args struct {
if to < from {
return []*Block{}, nil
}
ret := make([]*Block, 0, to-from+1)
var ret []*Block
for i := from; i <= to; i++ {
numberOrHash := rpc.BlockNumberOrHashWithNumber(i)
block := &Block{
Expand All @@ -1268,6 +1268,11 @@ func (r *Resolver) Blocks(ctx context.Context, args struct {
break
}
ret = append(ret, block)
select {
case <-ctx.Done():
return nil, ctx.Err()
default:
}
}
return ret, nil
}
Expand Down