internal/ethapi: remove error return value of RPCMarshalBlock #27449
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fjl
approved these changes
Jun 9, 2023
fjl
changed the title
devopsbo3
pushed a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
rm error when marshal block to rpc type allen
devopsbo3
added a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
…reum#27449)" This reverts commit e2e4193.
devopsbo3
added a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
…reum#27449)" This reverts commit e2e4193.
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Sep 29, 2025
Merged
19 tasks
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Sep 29, 2025
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Sep 30, 2025
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Oct 8, 2025
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Oct 8, 2025
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Oct 30, 2025
AnilChinchawale
pushed a commit
to XinFinOrg/XDPoSChain
that referenced
this pull request
Oct 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that there is no error return when marshal block to rpc type. Can we remove it?