Skip to content

eth: fix output file permissions in admin_exportChain #26912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 17, 2023
Merged

eth: fix output file permissions in admin_exportChain #26912

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b42ebd2
api: Use 0700 file permissions for ExportChain
Mar 17, 2023
8df9888
change perm to 0644
Mar 17, 2023
a2229b2
Update api.go
fjl Mar 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion eth/api.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ func (api *AdminAPI) ExportChain(file string, first *uint64, last *uint64) (bool
return false, errors.New("location would overwrite an existing file")
}
// Make sure we can create the file to export into
out, err := os.OpenFile(file, os.O_CREATE|os.O_WRONLY|os.O_TRUNC, os.ModePerm)
out, err := os.OpenFile(file, os.O_CREATE|os.O_WRONLY|os.O_TRUNC, os.FileMode(0700))
Copy link
Member

@karalabe karalabe Mar 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, os.ModePerm is a mask, not something to be used as a permission. Pls change to 0600 though, no need for execute bit.

Copy link
Contributor

@fjl fjl Mar 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be 0644 actually.

Copy link
Author

@darioush darioush Mar 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated.

if err != nil {
return false, err
}
Expand Down