common/compiler, cmd/abigen: remove solc/vyper compiler integration #24935
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if c.GlobalString(pkgFlag.Name) == "" { | ||
| utils.Fatalf("No destination package specified (--pkg)") | ||
| } | ||
| if c.GlobalString(abiFlag.Name) == "" { |
Member
There was a problem hiding this comment.
json can also be a source of abigen, right?
Contributor
Author
There was a problem hiding this comment.
bleh, that brings back solidity.go and ParseCombinedJSON ...
| "strings" | ||
|
|
||
| "github.com/ethereum/go-ethereum/accounts/abi" | ||
| "errors" |
Contributor
Author
|
I'll reopen this at a later point.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the integration with external compilers (solc, vyper).
The vyper-support in go-ethereum is flaky at best, considering that the vyper compiler itself has been a moving target in the latest years, so I don't believe that our integration works.
The solc compiler might "work", but would probably need some updates (#24925) in order to be more useful.
An alternative path, which this PR does, is remove the support, making it so that we only consume the ABI artefacts, which the compiler spits out. This makes geth more of a component in the pipeline rather than an orchestrator of the pipeline, and lessens the maintenance surface.