eth/gasprice: feeHistory improvements #23422
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zsfelfoldi
requested review from
holiman,
karalabe and
rjl493456442
as code owners
eth/gasprice/feehistory.go
Outdated
| block *types.Block // only set if reward percentiles are requested | ||
| receipts types.Receipts | ||
| // filled by processBlock | ||
| processedFees |
Member
There was a problem hiding this comment.
Can we separate the "result" out from the blockFees struct? It's not so nice to have the embedded struct(result).
rjl493456442
approved these changes
Aug 23, 2021
Member
rjl493456442
left a comment
rjl493456442
left a comment
There was a problem hiding this comment.
Nitpicks, otherwise lgtm.
eth/gasprice/feehistory.go
Outdated
| } | ||
| if fees.header != nil { | ||
| oracle.processBlock(fees, rewardPercentiles) | ||
| if fees.err == nil && !pending { |
Member
There was a problem hiding this comment.
nitpicks, it's not obvious that logic is using the cached result or process to get the result.
Can we send back the result by results <- fees immediately if we find the result in Cache?
So that the logic is more clear.
sidhujag
pushed a commit
to sidhujag/go-ethereum
that referenced
this pull request
Aug 23, 2021
* eth/gasprice: cache feeHistory results * eth/gasprice: changed feeHistory block count limitation * eth/gasprice: do not use embedded struct in blockFees * eth/gasprice: fee processing logic cleanup * eth/gasprice: purge feeHistory cache at chain reorgs
atif-konasl
pushed a commit
to frozeman/pandora-execution-engine
that referenced
this pull request
Oct 15, 2021
* eth/gasprice: cache feeHistory results * eth/gasprice: changed feeHistory block count limitation * eth/gasprice: do not use embedded struct in blockFees * eth/gasprice: fee processing logic cleanup * eth/gasprice: purge feeHistory cache at chain reorgs
This was referenced Sep 23, 2022
19 tasks
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the block count limitation rules in light client mode so that only the length of the queried section is limited per request but querying older sections of the chain is not limited. The feeHistory spec only mandates providing access to the most recent section because some clients might not be able to serve older data but the Geth light client is capable of doing so and therefore the limitations can be eased, allowing fee estimators to examine/sample a longer history if necessary.
The processed results are also cached per block now which greatly improves the performance of the calibration process of the Economical Fee Oracle.