core/types: sanity check the basefee length inside a header #23171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
holiman
approved these changes
Jul 6, 2021
|
Are there any sanity checks around the max value of the tip akin to the old 500 gwei gasprice fat finger cap? |
Member
Author
|
@tayvano Yes, the new tip estimator uses the exact same code as the old gas price estimator (just slightly modified to return a number without the base fee): https://github.com/ethereum/go-ethereum/blob/master/eth/gasprice/gasprice.go#L184 |
sidhujag
pushed a commit
to sidhujag/go-ethereum
that referenced
this pull request
Jul 10, 2021
atif-konasl
pushed a commit
to frozeman/pandora-execution-engine
that referenced
this pull request
Oct 15, 2021
This was referenced Sep 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EIP 1559 added a new unbounded type to the headers (base fee). This PR adds a meaningful can on top of it to prevent anyone from finding an ingenious way to do an amplification attack with junk basefees (with valid PoW).