Skip to content

Conversation

@zsfelfoldi
Copy link
Contributor

This PR adds the new consensus constraints of EIP-1559 transactions as specified here:
ethereum/EIPs#3594
Note: the same sanity checks are performed first during tx pool validation even though the previously existing filters would filter out the same transactions. This way the same error types can be returned by the pool and by consensus.

Copy link
Contributor

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
I pushed some minor changes, reducing the bigints in buygas, and making the big number exactly on the bitlength boundary.

@holiman holiman added this to the 1.10.4 milestone May 30, 2021
@zsfelfoldi
Copy link
Contributor Author

Please merge it if you have the necessary rights, I can't do that because of a random travis failure.

@holiman
Copy link
Contributor

holiman commented May 30, 2021

Odd, faucet_test.go:37: No Ethereum address found to fund -- failed on both appveyor jobs and one of the travis jobs. I can understand if it fails consistently on a platform where outgoing traffic is constrained, but I don't understand why it's flaky otherwise.

@holiman
Copy link
Contributor

holiman commented May 30, 2021

I had forgotten to push some of my changes. I squashed it into the last commit, ptal @zsfelfoldi

@holiman
Copy link
Contributor

holiman commented May 30, 2021

With these new rules in place, testing on baikal, I get

########## BAD BLOCK #########
Chain config: {ChainID: 1642 Homestead: 0 DAO: <nil> DAOSupport: true EIP150: 0 EIP155: 0 EIP158: 0 Byzantium: 0 Constantinople: 0 Petersburg: 0 Istanbul: 0, Muir Glacier: <nil>, Berlin: 0, London: 500, Engine: clique}

Number: 30084
Hash: 0x53805e3c841d3627555e13cd65d2f70cde22d44b73f6d884879b205a9b4e8dee


Error: could not apply tx 0 [0xd3a10c0327569f01245f89a2b435b26e40017ae7e94ac525467390899d18244d]: tip higher than fee cap: address 0xBaaDF00d42264eEb3FAFe6799d0b56cf55DF0F00, tip: 10000000000, feeCap: 340282366920938463463374607431768211455

Which seems correct

@holiman holiman merged commit 2d716c4 into ethereum:master May 30, 2021
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants