Skip to content

metrics/influxdb: updating package to support InfluxDB v2 #22726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

metrics/influxdb: updating package to support InfluxDB v2 #22726

wants to merge 1 commit into from

Conversation

@italoacasas
Copy link

@italoacasas italoacasas commented Apr 23, 2021 •
edited
Loading

Issue #22646

  • Currently, only InfluxDB v1.x works in the client, this PR will allow v2 to work, but v1 will not work anymore.
  • Opening the PR as a draft to get some feedback
  • I took the liberty to delete some methods that no one was using

@MariusVanDerWijden
Copy link
Member

MariusVanDerWijden commented Apr 23, 2021

I ran into the same issue over here: #22664
I'm not sure if we can disable v1 quite yet though @fjl

@italoacasas
Copy link
Author

italoacasas commented Apr 23, 2021 •
edited
Loading

@MariusVanDerWijden If v1 cannot be dropped, maybe using https://docs.influxdata.com/influxdb/v2.0/reference/api/influxdb-1x/, we can build a compatible layer using the v2 go client

@holiman holiman self-assigned this Apr 29, 2021
@jwasinger jwasinger mentioned this pull request Jul 11, 2021
Merged
@holiman
Copy link
Contributor

holiman commented Oct 31, 2021

Fixed by #23194, closing this

@holiman holiman closed this Oct 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@holiman holiman

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@italoacasas @MariusVanDerWijden @holiman