fix/workaround for issue #22434 #22511
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@holiman this wasn't the right fix 😓 |
gballet
added a commit
to gballet/go-ethereum
that referenced
this pull request
Mar 23, 2021
This reverts commit ec73ec0.
atif-konasl
pushed a commit
to frozeman/pandora-execution-engine
that referenced
this pull request
Oct 15, 2021
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, I believe I've come up with a solution to a build bug that I found, though I'm not sure if this is a proper fix or just a workaround.
The issue: #22434
Notes on how I came up with this solution: https://gist.github.com/tobias-hildebrandt/d4b13fd15e282c5b77b7ed24a6b3650d
In my fix, I also had to generate files for gopsutil, so a pull request might also have to be made there as well.
I'm not too experienced with git, so I expect that the commits will have to be changed around. Please let me know what else is required of me. Feel free to edit anything so that it aligns to any project-wide guidelines. Thanks!