Skip to content

cmd/devp2p: only run eth66 tests against supporting node #22460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 19, 2021
Merged

cmd/devp2p: only run eth66 tests against supporting node #22460

merged 3 commits into from
Mar 19, 2021

Conversation

@renaynay
Copy link
Contributor

@renaynay renaynay commented Mar 8, 2021

This PR fixes an issue where the eth test suite would also run eth66 protocol version tests against the node even if the node does not support eth66.

@renaynay renaynay requested a review from fjl March 8, 2021 13:37
holiman
holiman approved these changes Mar 16, 2021
View reviewed changes
Copy link
Contributor

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@holiman
Copy link
Contributor

holiman commented Mar 16, 2021

Travis says no:

--- FAIL: TestEthProtocolNegotiation (0.00s)
    --- FAIL: TestEthProtocolNegotiation/0 (0.00s)
        chain_test.go:69: 
            	Error Trace:	chain_test.go:69
            	Error:      	Not equal: 
            	            	expected: 0x41
            	            	actual  : 0x0
            	Test:       	TestEthProtocolNegotiation/0
    --- FAIL: TestEthProtocolNegotiation/1 (0.00s)
        chain_test.go:69: 
            	Error Trace:	chain_test.go:69
            	Error:      	Not equal: 
            	            	expected: 0x41
            	            	actual  : 0x0
            	Test:       	TestEthProtocolNegotiation/1
    --- FAIL: TestEthProtocolNegotiation/2 (0.00s)
        chain_test.go:69: 
            	Error Trace:	chain_test.go:69
            	Error:      	Not equal: 
            	            	expected: 0x40
            	            	actual  : 0x0
            	Test:       	TestEthProtocolNegotiation/2
FAIL

@fjl fjl merged commit d3040a8 into ethereum:master Mar 19, 2021
atif-konasl pushed a commit to frozeman/pandora-execution-engine that referenced this pull request Oct 15, 2021
@renaynay @atif-konasl
cmd/devp2p/internal/ethtest: skip eth/66 tests when v66 not supported (…
60c6980 
…ethereum#22460)
@quorumbot quorumbot mentioned this pull request Apr 28, 2022
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fjl fjl Awaiting requested review from fjl

1 more reviewer

@holiman holiman holiman approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@renaynay @holiman @fjl