Skip to content

les: allow either full enode strings or raw hex ids in the API #22423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 16, 2021
Merged

les: allow either full enode strings or raw hex ids in the API #22423

merged 1 commit into from
Mar 16, 2021
+45 −6

Conversation

@zsfelfoldi
Copy link
Contributor

@zsfelfoldi zsfelfoldi commented Mar 3, 2021

This PR improves the LES priority API functions by accepting both raw hex node IDs (like before) and full enode strings.

Now each of the following forms are accepted:

les.addBalance("8d3797578a393adbe77af76c6d0f6fee8c4d402d235ad9fa93f8f20eb9bc0dad", 10000000000000)
les.addBalance("0x8d3797578a393adbe77af76c6d0f6fee8c4d402d235ad9fa93f8f20eb9bc0dad", 10000000000000)
les.addBalance("enode://4f3fb4e87c51057126d79ea0473bb7432b056456737e77e9977c5a72268b31a42dcaf2b7f0c03bc656fb0b8da093490c22cdc972494c9801f0858e5a903c693b@127.0.0.1:37214", 10000000000000)

@zsfelfoldi zsfelfoldi requested a review from rjl493456442 as a code owner March 3, 2021 13:59
@holiman holiman added this to the 1.10.2 milestone Mar 16, 2021
@holiman holiman merged commit 91726e8 into ethereum:master Mar 16, 2021
0racl3z
0racl3z reviewed Mar 18, 2021
View reviewed changes
Copy link

@0racl3z 0racl3z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx!

atif-konasl pushed a commit to frozeman/pandora-execution-engine that referenced this pull request Oct 15, 2021
@zsfelfoldi @atif-konasl
les: allow either full enode strings or raw hex ids in the API (ether…
0d7ec82 
…eum#22423)
@quorumbot quorumbot mentioned this pull request Apr 28, 2022
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rjl493456442 rjl493456442 rjl493456442 approved these changes

+1 more reviewer

@0racl3z 0racl3z 0racl3z left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.10.2

Development

Successfully merging this pull request may close these issues.

4 participants

@zsfelfoldi @rjl493456442 @0racl3z @holiman