-
Notifications
You must be signed in to change notification settings - Fork 21.5k
event: resubscribe with error handler #22191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Added a possibility to pass a custom callback function which will be invoked on subscription error. This change will allow clients to receive the original subscription error and perform some additional actions like logging to make debugging easier.
|
Thanks for this change. It looks very useful, but I think we can do it with just one callback. The I'm mostly suggesting this because I want to avoid having two callback parameters |
Instead of creating a new callback parameter one can use a new resubscribe function type to pass the last subscription error as its second argument.
|
Thanks for the review @fjl. I changed the code according to your suggestion. |
This adds a way to get the error of the failing subscription for logging/debugging purposes. Co-authored-by: Felix Lange <[email protected]>
This adds a way to get the error of the failing subscription for logging/debugging purposes. Co-authored-by: Felix Lange <[email protected]>
This adds a way to get the error of the failing subscription for logging/debugging purposes. Co-authored-by: Łukasz Zimnoch <[email protected]> Co-authored-by: Felix Lange <[email protected]>
Added a possibility to pass a custom callback function which will be invoked on subscription error.
This change will allow clients to receive the original subscription error and perform some additional actions like logging to make debugging easier.