Fix queue slicing #22181
Merged
Fix queue slicing #22181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This seems to be a bug. Usually the two values are the same but when they are not this can cause a negative starting position. It looks like this was copied from above but the variable name was not changed.
dadeg
requested review from
holiman,
karalabe and
rjl493456442
as code owners
holiman
approved these changes
Jan 16, 2021
Contributor
|
Thanks! |
bulgakovk
pushed a commit
to bulgakovk/go-ethereum
that referenced
this pull request
Jan 26, 2021
9 tasks
9 tasks
This was referenced Sep 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to be a bug. Usually the two values are the same but when they are not this can cause a negative starting position. It looks like this was copied from above but the variable name was not changed.