internal/ethapi: restore net_version RPC method #22061
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During the snap and eth refactor, the net_version rpc call was falsely deprecated. This reenables the net_version RPC handler as most eth2 nodes and other software depends on it.
MariusVanDerWijden
requested review from
holiman,
karalabe,
rjl493456442 and
zsfelfoldi
as code owners
fjl
approved these changes
Dec 23, 2020
fjl
changed the title
fjl
changed the title
9 tasks
9 tasks
This was referenced Sep 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the snap and eth refactor, the net_version rpc call was falsely deprecated.
This reenables the net_version RPC handler as most eth2 nodes and other software
depends on it.
closes #22059
closes #22057
closes #22034