eth/download/statesync : state hash sum optimized #22035
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ucwong
requested review from
holiman,
karalabe and
rjl493456442
as code owners
Member
|
Is there any benefit? E.g. is there any performance speedup? Would be nice to have some benchmarks. We are inclined to not accept the changes if it's basically noop. |
holiman
reviewed
Dec 18, 2020
eth/downloader/statesync.go
Outdated
Comment on lines
29
to
30
| "sync" | ||
| "time" |
Contributor
Yes, |
Contributor
|
Similar one in a different area: https://github.com/ethereum/go-ethereum/pull/22023/files |
Contributor
|
Thanks! |
9 tasks
9 tasks
This was referenced Sep 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.