cmd/faucet: protect f.reqs with Rlock to prevent data race #20669
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update to go-ethereum master
Member
|
Thanks for the PR, however this will lock the faucet for the entire duration of the network transmission, which is not a good idea. If |
karalabe
approved these changes
Feb 15, 2020
Member
karalabe
left a comment
karalabe
left a comment
There was a problem hiding this comment.
This change does not do a deep copy of f.reqs, so it's not ultra safe, but we only ever append and slice it (never update an entry), so it should be fine.
7 tasks
enriquefynn
pushed a commit
to enriquefynn/go-ethereum
that referenced
this pull request
Mar 10, 2021
…20669) * cmd/faucet: add Rlock to protect f.reqs in apiHandler * cmd/faucet: make a locked copy of f.reqs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In cmd/faucet/faucet.go,
f.reqsis protected byf.lock.Lock()orf.lock.Rlock()at five places.The only place where it is not protected is on L367 in func
apiHandler().This may cause data race when
apiHandler()and other func likerefresh()wheref.reqsis written to are called in parallel.The fix is to use
f.lock.Rlock()to protectf.reqs.