build: disable swarm packages #19585
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skylenet
approved these changes
May 16, 2019
karalabe
reviewed
May 16, 2019
build/ci.go
Outdated
Member
There was a problem hiding this comment.
This looks funky :) I assume you want to get rid of allCrossCompiledArchiveFiles altogether and just inline allToolsArchiveFiles instead.
Member
Author
There was a problem hiding this comment.
I was also surprised it even compiles. Yes, will get rid of allCrossCompiledArchiveFiles, and just use allToolsArchiveFiles.
Member
Author
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is disabling automatic builds for Swarm packages, and basically decoupling the Swarm release process from Geth.
From now on until we split the Swarm codebase from the Geth repo, we will issue manually releases of Swarm.