Skip to content

Backport PR for the v1.8.24 maintenance release #19370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Apr 8, 2019
Merged

Backport PR for the v1.8.24 maintenance release #19370

merged 11 commits into from
Apr 8, 2019

Conversation

@karalabe
Copy link
Member

@karalabe karalabe commented Apr 2, 2019 •
edited
Loading

See release notes.

@karalabe karalabe requested a review from zsfelfoldi as a code owner April 2, 2019 09:11
@karalabe karalabe requested a review from holiman as a code owner April 8, 2019 08:49
holiman
holiman approved these changes Apr 8, 2019
View reviewed changes
Copy link
Contributor

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM so far

karalabe and others added 8 commits April 8, 2019 12:00
@karalabe
trie: there's no point in retrieving the metaroot
80a2a35
@holiman @karalabe
all: simplify timestamps to uint64 (#19372)
af401d0 
* all: simplify timestamps to uint64

* tests: update definitions

* clef, faucet, mobile: leftover uint64 fixups

* ethash: fix tests

* graphql: update schema for timestamp

* ethash: remove unused variable
@karalabe
travis: update builders to xenial to shadow Go releases
442320a
@rjl493456442 @karalabe
core: re-omit new log event when logs rebirth
f1b00cf
@karalabe
core: minor code polishes + rebase fixes
0e63a70
@karalabe
params: set Rinkeby Petersburg fork block (4th May, 2019)
8ca6454
@fjl @karalabe
p2p/discover: bump failure counter only if no nodes were provided (#1…
9d9c6b5 
…9362)

This resolves a minor issue where neighbors responses containing less
than 16 nodes would bump the failure counter, removing the node. One
situation where this can happen is a private deployment where the total
number of extant nodes is less than 16.

Issue found by @Jsying.
@holiman @karalabe
eth, les, geth: implement cli-configurable global gas cap for RPC cal…
e872ba7 
…ls (#19401)

* eth, les, geth: implement cli-configurable global gas cap for RPC calls

* graphql, ethapi: place gas cap in DoCall

* ethapi: reformat log message
@karalabe karalabe requested a review from fjl as a code owner April 8, 2019 12:15
@karalabe karalabe merged commit 4e13a09 into ethereum:release/1.8 Apr 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zsfelfoldi zsfelfoldi Awaiting requested review from zsfelfoldi zsfelfoldi is a code owner

@fjl fjl Awaiting requested review from fjl fjl is a code owner

1 more reviewer

@holiman holiman holiman approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@karalabe @holiman @rjl493456442 @fjl