core, ethdb, trie: mode dirty data to clean cache on flush #19307
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karalabe
changed the title
This was referenced Mar 25, 2019
holiman
commented
Mar 25, 2019
karalabe
reviewed
Mar 25, 2019
trie/database.go
Outdated
Member
There was a problem hiding this comment.
Yes, this is a cluster-f*ck. That said, the trie database write access is serialized by the blockchain importer, since we can't import two blocks concurrently. The only thing this code needs to ensure is that API CALL operations, sync state retrievals, etc don't mess up. The blockchain guarantees that no write will intervene here.
fjl
reviewed
Mar 25, 2019
holiman
commented
Mar 25, 2019
fjl
reviewed
Mar 25, 2019
fjl
requested changes
Mar 25, 2019
Contributor
fjl
left a comment
fjl
left a comment
There was a problem hiding this comment.
As per our long discussion on Discord, please remove read locking from Commit and Cap. Please also document that Commit and Cap are not safe for concurrent use.
fjl
approved these changes
Mar 26, 2019
4 tasks
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a more advanced form of the dirty-to-clean cacher (#18995), where we reuse previous database write batches as datasets to uncache, saving a dirty-trie-iteration and a dirty-trie-rlp-reencoding per block.