-
Notifications
You must be signed in to change notification settings - Fork 21.5k
swarm/network: WIP consider all nodes for healthy iteration #19155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
acud
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM except for a few code-style comments.
The strange thing about this is that I had a feeling that the AddNodes and ConnectNodesX would actually block. Judging by the results of the snapshot it means that both these methods return and potentially before the nodes were even up? This is quite strange. Moreover considering that the Node.Up is set to be true when creating the node - they should all be up after create.go#L82. We should add a panic in Net.ConnectX when the Up node count does not equal the parameter value.
swarm/network/simulation/kademlia.go
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can be removed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why?
|
@holisticode there is a consistent CI failure on snapshot creation |
cmd/swarm/swarm-snapshot/create.go
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should just use AddNodesAndConnectRing here
addresses ethersphere/swarm#1263
This PR corrects two problems with the existing
WaitTillHealthyimplementation.ConnectNN, should instead callHealthy()