cmd/utils, eth: relinquish GC cache to read cache in archive mode #18991
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
holiman
reviewed
Feb 5, 2019
Member
Author
|
@holiman Fixed the MiB, PTAL |
19 tasks
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Dec 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a partial solution for #16237 and #18984 so that archive mode does not hog the write cache memory allowance, since it doesn't keep dirty stuff in memory either way. Might as well use all that memory for the read cache.
It does not yet fully address the issue, since we also need a mechanism to move dirty stuff into the write cache on commit, so don't close the linked issues on merge.
Benchmark running on mon08/mon09. I'm not seeing any significant enough difference to care in either direction. Master seems a bit faster, but compaction dwarfs both runtimes.