truncateQueue method drops the newest txs rather than the oldest ones.

[zhaochonghe]

go-ethereum/core/tx_pool.go

Line 1462 in 5c5ef6f

// truncateQueue drops the oldes transactions in the queue if the pool is above the global queue limit.

According to its annotation, it seems to drop the oldest txs first when the length of queue is above the global queue limit.

go-ethereum/core/tx_pool.go

Line 1483 in 5c5ef6f

addr := addresses[len(addresses)-1]

But actually, it first drops the newest txs (the last element in addresses), since the elements in addresses are ordered from oldest to newest . Should it change to addr := addresses[0] ?

[holiman]

Indeed, can confirm.
An alternative way to fix it would be to change the sorting to sort.Sort(sort.Reverse(addresses))

[holiman]

Fixed by #24908