Skip to content

Conversation

@spencer-tb
Copy link
Contributor

@spencer-tb spencer-tb commented Oct 16, 2025

🗒️ Description

PR to create releases from EELS to EEST. Tags in EELS for releases must now be prefixed with tests-.

Remaining Todos

  • Test full releases:
    • v5.4.0 or a special v6.0.0 (EELS release) 💡
  • Test feature releases:
    • BAL 💡 (with EELS) has to wait until this is merged and forks/amsterdam is rebased onto forks/osaka. Not a blocker.
    • Benchmark 💡 (with evmone). Not a blocker. But a quick test to check we can create a feature release with another evm should be required.

How To Create A Fixture Release

🔗 Related Issues or PRs

N/A

✅ Checklist

  • All: Ran fast tox checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:
    uvx --with=tox-uv tox -e static
  • All: PR title adheres to the repo standard - it will be used as the squash commit message and should start type(scope):.
  • All: Considered adding an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • All: Set appropriate labels for the changes (only maintainers can apply labels).

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

Carsons-Eels pushed a commit to Carsons-Eels/execution-specs that referenced this pull request Oct 16, 2025
…ethereum#1608)

* tests(gentest): don't use default output fixture directory in unit test

* feat(fill): refuse to fill to a non-empty output directory; add clean

* test(fill): add tests for fixture output dir args/`FixtureOutput`

* chore(tox): use a dedicated dir in /tmp and --clean when filling tests

* docs: update changelog

* Apply suggestions from code review

---------

Co-authored-by: Mario Vega <[email protected]>
danceratopz added a commit to danceratopz/execution-specs that referenced this pull request Oct 22, 2025
…ethereum#1608)

* tests(gentest): don't use default output fixture directory in unit test

* feat(fill): refuse to fill to a non-empty output directory; add clean

* test(fill): add tests for fixture output dir args/`FixtureOutput`

* chore(tox): use a dedicated dir in /tmp and --clean when filling tests

* docs: update changelog

* Apply suggestions from code review

---------

Co-authored-by: Mario Vega <[email protected]>
@spencer-tb spencer-tb force-pushed the test-fixture-workflows branch from 10aefe6 to f993d19 Compare October 22, 2025 14:58
@spencer-tb spencer-tb changed the title feat(weld): create releases in EEST from EELS (WIP) feat(weld): create releases in EEST from EELS Oct 22, 2025
@spencer-tb spencer-tb changed the title feat(weld): create releases in EEST from EELS feat(ci): create releases in EEST from EELS Oct 22, 2025
@spencer-tb spencer-tb added E-medium Experience: of moderate difficulty P-high Finalize Weld A-ci Area: Continuous Integration labels Oct 22, 2025
@spencer-tb spencer-tb marked this pull request as ready for review October 22, 2025 15:45
Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments, and I think we should simply add besu/ethjs back, even if we are not currently using them, we could break their CI or someone else's if they are using it.

@marioevz marioevz force-pushed the test-fixture-workflows branch from 2c880d8 to 542a0ba Compare October 22, 2025 17:00
Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

I think we can merge and setup the token after it has been addressed, do a test release, and then a follow-up PR if anything needs fixing.

@codecov-commenter
Copy link

codecov-commenter commented Oct 22, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.08%. Comparing base (da0c26e) to head (80377f8).
⚠️ Report is 4 commits behind head on forks/osaka.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##           forks/osaka    #1608   +/-   ##
============================================
  Coverage        86.08%   86.08%           
============================================
  Files              743      743           
  Lines            44072    44072           
  Branches          3891     3891           
============================================
  Hits             37938    37938           
  Misses            5656     5656           
  Partials           478      478           
Flag Coverage Δ
unittests 86.08% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@spencer-tb spencer-tb force-pushed the test-fixture-workflows branch 2 times, most recently from c83a78d to dce1195 Compare October 23, 2025 14:02
chetna-mittal pushed a commit to gnosischain/execution-specs that referenced this pull request Oct 24, 2025
…ethereum#1608)

* tests(gentest): don't use default output fixture directory in unit test

* feat(fill): refuse to fill to a non-empty output directory; add clean

* test(fill): add tests for fixture output dir args/`FixtureOutput`

* chore(tox): use a dedicated dir in /tmp and --clean when filling tests

* docs: update changelog

* Apply suggestions from code review

---------

Co-authored-by: Mario Vega <[email protected]>
Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one other comment, thanks!

@spencer-tb spencer-tb force-pushed the test-fixture-workflows branch 3 times, most recently from 8e2cb7f to 3b5c92b Compare October 27, 2025 17:00
@spencer-tb spencer-tb force-pushed the test-fixture-workflows branch 3 times, most recently from 9e6660a to d15f7a4 Compare October 29, 2025 10:01
Copy link
Member

@danceratopz danceratopz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing, thanks @spencer-tb!

Could we rename:

# for consistent extension yml/yaml
git mv .github/actions/build-evm-client/ethjs/action.yml .github/actions/build-evm-client/ethjs/action.yaml

# for more descriptive names
git mv .github/workflows/fixtures.yaml .github/workflows/fixture_full_release.yaml
git mv .github/workflows/fixtures_feature.yaml .github/workflows/fixture_feature_release.yaml

I would love to remove the awk/sed and replace with a Python script similar to .github/scripts/get_release_props.py, but happy to do that as a follow-up!

@spencer-tb spencer-tb force-pushed the test-fixture-workflows branch from 3f2a48a to ef169e6 Compare October 29, 2025 13:11
@spencer-tb spencer-tb merged commit e8cadfb into ethereum:forks/osaka Oct 29, 2025
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ci Area: Continuous Integration E-medium Experience: of moderate difficulty Finalize Weld P-high

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants