-
Notifications
You must be signed in to change notification settings - Fork 370
feat(ci): create releases in EEST from EELS #1608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ci): create releases in EEST from EELS #1608
Conversation
…ethereum#1608) * tests(gentest): don't use default output fixture directory in unit test * feat(fill): refuse to fill to a non-empty output directory; add clean * test(fill): add tests for fixture output dir args/`FixtureOutput` * chore(tox): use a dedicated dir in /tmp and --clean when filling tests * docs: update changelog * Apply suggestions from code review --------- Co-authored-by: Mario Vega <[email protected]>
…ethereum#1608) * tests(gentest): don't use default output fixture directory in unit test * feat(fill): refuse to fill to a non-empty output directory; add clean * test(fill): add tests for fixture output dir args/`FixtureOutput` * chore(tox): use a dedicated dir in /tmp and --clean when filling tests * docs: update changelog * Apply suggestions from code review --------- Co-authored-by: Mario Vega <[email protected]>
10aefe6 to
f993d19
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments, and I think we should simply add besu/ethjs back, even if we are not currently using them, we could break their CI or someone else's if they are using it.
2c880d8 to
542a0ba
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
I think we can merge and setup the token after it has been addressed, do a test release, and then a follow-up PR if anything needs fixing.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## forks/osaka #1608 +/- ##
============================================
Coverage 86.08% 86.08%
============================================
Files 743 743
Lines 44072 44072
Branches 3891 3891
============================================
Hits 37938 37938
Misses 5656 5656
Partials 478 478
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
c83a78d to
dce1195
Compare
…ethereum#1608) * tests(gentest): don't use default output fixture directory in unit test * feat(fill): refuse to fill to a non-empty output directory; add clean * test(fill): add tests for fixture output dir args/`FixtureOutput` * chore(tox): use a dedicated dir in /tmp and --clean when filling tests * docs: update changelog * Apply suggestions from code review --------- Co-authored-by: Mario Vega <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one other comment, thanks!
8e2cb7f to
3b5c92b
Compare
packages/testing/src/execution_testing/fixtures/pre_alloc_groups.py
Outdated
Show resolved
Hide resolved
9e6660a to
d15f7a4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing, thanks @spencer-tb!
Could we rename:
# for consistent extension yml/yaml
git mv .github/actions/build-evm-client/ethjs/action.yml .github/actions/build-evm-client/ethjs/action.yaml
# for more descriptive names
git mv .github/workflows/fixtures.yaml .github/workflows/fixture_full_release.yaml
git mv .github/workflows/fixtures_feature.yaml .github/workflows/fixture_feature_release.yaml
I would love to remove the awk/sed and replace with a Python script similar to .github/scripts/get_release_props.py, but happy to do that as a follow-up!
packages/testing/src/execution_testing/fixtures/pre_alloc_groups.py
Outdated
Show resolved
Hide resolved
Co-authored-by: danceratopz <[email protected]>
3f2a48a to
ef169e6
Compare
🗒️ Description
PR to create releases from EELS to EEST. Tags in EELS for releases must now be prefixed with
tests-.Remaining Todos
forks/amsterdamis rebased ontoforks/osaka. Not a blocker.How To Create A Fixture Release
git tag tests-v6.0.0 && git push upstream v6.0.0git tag [email protected] && git push upstream [email protected]as an example!🔗 Related Issues or PRs
N/A
✅ Checklist
toxchecks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:uvx --with=tox-uv tox -e statictype(scope):.Cute Animal Picture